[SYCL] Fix error with type aliases used as free function kernel args #20123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes type name that is being printed as free function kernel argument type in its forward-declaration in the integration header. Before the change, we used the original argument type name, which could be an alias - this patch makes use of the canonical type's name to make sure that all type aliases are "unwrapped".
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Fznamznon
reviewed
Sep 18, 2025
| template<typename T> | ||
| [[__sycl_detail__::add_ir_attributes_function("sycl-nd-range-kernel", 2)]] | ||
| void bar_using(ns::BarUsing<T> Arg) {} | ||
| template void bar_using(ns::BarUsing<int>); |
There was a problem hiding this comment.
Does something like
class A {
public:
using B = int;
};
void freefu(A::B a) {
}
work?
There was a problem hiding this comment.
Yes, it works, I added it as a test case in e327133
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Fznamznon
approved these changes
Sep 18, 2025
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Failures in compatibility test suite are unrelated: this PR only changes integration header generation for free function kernels, but neither of failed tests uses the feature: I will proceed with merge |
AlexeySachkov
deleted the
private/asachkov/fix-using-type-aliases-as-free-function-kernel-args
branch
AlexeySachkov
added a commit
to AlexeySachkov/llvm
that referenced
this pull request
Sep 29, 2025
…ntel#20123) This PR fixes type name that is being printed as free function kernel argument type in its forward-declaration in the integration header. Before the change, we used the original argument type name, which could be an alias - this patch makes use of the canonical type's name to make sure that all type aliases are "unwrapped".
AlexeySachkov
added a commit
that referenced
this pull request
Sep 30, 2025
This is joined cherry-pick of #20187 and #20123 --- [SYCL] Allow free function kernel args be templated on integer expressions (#20187) `constexpr` variables are not forward-declarable so if one is used as a template parameter of a free function kernel argument, we cannot reference the variable, but must inline the value into the integration header. --- [SYCL] Fix error with type aliases used as free function kernel args (#20123) This PR fixes type name that is being printed as free function kernel argument type in its forward-declaration in the integration header. Before the change, we used the original argument type name, which could be an alias - this patch makes use of the canonical type's name to make sure that all type aliases are "unwrapped".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes type name that is being printed as free function kernel argument type in its forward-declaration in the integration header.
Before the change, we used the original argument type name, which could be an alias - this patch makes use of the canonical type's name to make sure that all type aliases are "unwrapped".